feat: add lens and farcaster to user profile - Githubissues

snapshot-labs / sx-monorepo

Snapshot X monorepo

https://docs.snapshotx.xyz

MIT License

11 stars 10 forks source link

feat: add lens and farcaster to user profile #419

Closed wa0x6e closed 3 days ago

wa0x6e commented 2 weeks ago

Summary

Closes: #406

Features

Add support for lens and farcaster social network on user profile

Fixes

fix an issue where a new user couldn't be saved without filling all fields
show an error message when the user ID is not a valid address (before, /profile/hello) was loading an empty user)
fix an issue where the User page was flashing with "User does not exist" briefly on after update

How to test

Go to your user profile
Edit it to fill a lens and farcaster handles
It should appear on your profile

TODO

[x] Waiting for merging of https://github.com/snapshot-labs/snapshot.js/pull/1027

wa0x6e commented 2 weeks ago

Form looks good, but it fail to save

Yes, waiting for sdk and sequencer update

Sekhmet commented 1 week ago

Unrelated to this PR I think, but I can't save my profile, unless I set all fields.

My user account is full of null's even when it shouldn't based on types (it should be string or undefined).

wa0x6e commented 1 week ago

Unrelated to this PR I think, but I can't save my profile, unless I set all fields.

My user account is full of null's even when it shouldn't based on types (it should be string or undefined).

fixed