search

snapshot-labs / sx-monorepo

Snapshot X monorepo
https://docs.snapshotx.xyz
MIT License
11 stars 10 forks source link

feat: only fail waitForTransaction if it's missing or reverted #421

Closed Sekhmet closed 2 weeks ago

Sekhmet commented 2 weeks ago

Summary

Previously any failure in fetching receipt would result in waitForTransaction failing after 20 attempts. This means non-related errors (like rate limits) would cause it to fail, even though transaction has completed.

This PR changes this behavior, it will only fail if:

  1. Transaction was missing for 60 attempts (2 minutes).
  2. It was reverted.

Closes: https://github.com/snapshot-labs/sx-monorepo/issues/409

How to test

  1. Create Starknet space.