search

snapshot-labs / sx-monorepo

Snapshot X monorepo
https://docs.snapshotx.xyz
MIT License
11 stars 10 forks source link

feat: store proposal_threshold as BigDecimal #445

Closed Sekhmet closed 1 week ago

Sekhmet commented 1 week ago

Summary

Int is not big enough to store all our values.

How to test

  1. Run yarn dev:full.
  2. Run following query at sx-api.
  3. Values are returned as strings.
{
  spaces {
    proposal_threshold
  }
}
bonustrack commented 1 week ago

Did you tested with the UI if it doesn't break?

Sekhmet commented 1 week ago

Haven't tested, but we actually expected it to be string all along on the UI (and subgraph APIs use string already).