Closed Sekhmet closed 2 days ago
I created this proposal and it got accepted at ~3:14 on a space with a 10mn voting delay: http://localhost:8080/#/sn-sep:0x003014ce1db98b66a83e6e01cf79d157d0cc49d139612156bc95bc2ff1a01e2e/proposal/3 Does this looks correct to you?
Created is ~5mn behind, this is confusing, start is 10mn away from created which makes sense for an user in term of delay but then I don't see the extra 10mn added because using ERC20 Votes strategy. Shouldn't we show instead a created at 3:14 and starting at 3:24?
@bonustrack it adds 10 minutes to block time, not real time when discovered.
This proposal was created in this transaction.
Block in which it was included was created at 3:08
so we have to wait til next block (so 3:18
).
If we use real time references then it will have to wait to 3:24
, but this will actually end up being 16 minutes of wait time.
So in current approach proposal is pending for 4 minutes, after that you can vote and see VP. If we added 10m to current time it would end up being pending for whole 10 minutes.
Summary
This PR adds three changes related to handling ERC20Votes strategies
snapshot
won't be passed togetVotingValue
- instead live value will be computed (this would cause VP fail to load, due to timestamp in the future).created
timestamp derived from proposal metadata meaning that it will have accurate timestamp (eliminating possibility of proposal starting before it's created) (https://github.com/snapshot-labs/sx-monorepo/issues/413)Closes: https://github.com/snapshot-labs/sx-monorepo/issues/413
How to test
yarn dev:full
.