search

snapshot-labs / sx-monorepo

Snapshot monorepo
https://snapshot.box
MIT License
14 stars 12 forks source link

fix: fix wrong network explorer url for strategies #466

Closed wa0x6e closed 3 months ago

wa0x6e commented 3 months ago

Summary

Closes: #434

Fix an issue where the explorer url for a voting power strategy is on the wrong network

How to test

  1. Go to http://localhost:8080/#/sn-sep:0x0141464688e48ae5b7c83045edb10ecc242ce0e1ad4ff44aca3402f7f47c1ab9/proposals or http://localhost:8080/#/sn:0x071977084d73002fed430d99108da39d241b900099ccc2a4cdcb7d5041d851d2/proposals
  2. Open the voting power modal
  3. All links to the explorer should use the same network (etherscan/starkscan) as the space, but storage proof strategies (which will always use etherscan)
bonustrack commented 3 months ago

For OZ storage proof strategy, EVM slot value and others storage proof related strategy it should link to Etherscan not Starkscan, here is a space with storage proof and common strategies: http://localhost:8080/#/sn:0x071977084d73002fed430d99108da39d241b900099ccc2a4cdcb7d5041d851d2/proposals

wa0x6e commented 3 months ago

Is there any other exceptions/uses cases?

bonustrack commented 3 months ago

No, but storage proof have many different strategies, SN mainnet and SN Sepolia strategies are different

wa0x6e commented 3 months ago

No, but storage proof have many different strategies, SN mainnet and SN Sepolia strategies are different

So all storage proof strategies should use etherscan?

bonustrack commented 3 months ago

Yes, it will either be Ethereum mainnet or Sepolia