search

snapshot-labs / sx-monorepo

Snapshot monorepo
https://snapshot.box
MIT License
16 stars 16 forks source link

bug: duplicates items in pagination #480

Open wa0x6e opened 3 months ago

wa0x6e commented 3 months ago

On large leaderboard pages where users have same proposals/votes count, some address appear twice due to pagination

On some edge case, this issue may also appear in the space profile page, where we could have duplicates spaces, when user have activities with same counter on multiple spaces

Edit: this issue is more global, and affecting all graphql queries returning a lot of data. Seems like only onchain is affected, as on the hub, we're internally sorting by an additional id column

wa0x6e commented 3 months ago

We fixed this issue on the hub by always sorting by multiple columns, in addition of the requested one.

For onchain, not sure of the fix, as graphql does not allow sorting by multiple fields

wa0x6e commented 3 months ago

Seems like the issue is more global, and affecting other endpoint like votes (https://discord.com/channels/955773041898573854/1030773050217615440/1266434986970578954)

Issue title has been updated to reflect that