search

snapshot-labs / sx-monorepo

Snapshot monorepo
https://snapshot.box
MIT License
13 stars 11 forks source link

feat: add network switcher for argent X #546

Closed wa0x6e closed 5 days ago

wa0x6e commented 1 month ago

Like we already do for EVM, we should trigger a wallet network switch on Starknet when the action is not on the correct chain.

This will avoid invalid signature with Argent X, when signing message on a different chainId than the wallet (braavos can sign message on any networks).

The wallet is supporting the networks switch call, see https://github.com/argentlabs/argent-x/blob/0607c5e58742dd33b3737e898ca78e97d7c4fb44/packages/dapp/src/services/wallet.service.ts#L250-L260

Feature should be implemented once:

Sekhmet commented 1 month ago

We wanted to implement it before, but it didn't work back then (the call was ignored), we should verify if it's functional.

wa0x6e commented 1 month ago

Will check

wa0x6e commented 1 week ago

Regarding different actions support for starknet wallets: https://github.com/starknet-io/get-starknet/issues/212