search

snapshot-labs / sx-starknet

Core smart contracts of Snapshot X for Starknet
https://docs.snapshotx.xyz
MIT License
118 stars 71 forks source link

refactor: N-06 Incomplete Encapsulation #589

Closed pscott closed 1 year ago

pscott commented 1 year ago

Closes #568

Orland0x commented 1 year ago

do you think this is worth it considering it will then deviate from sx-evm? I assume the sx.js clients will use a lot of the same code for the solidity contracts in sx-sn and sx-evm particularly

pscott commented 1 year ago

Brings the question: should we also update this on SX-EVM side maybe?

Orland0x commented 1 year ago

Brings the question: should we also update this on SX-EVM side maybe?

Dont think its really worth it post audit, feels like a minor/debatable thing.

Its the responsibility of external integrators to check the interfaces of the contracts they interact with. its not like we are implementing some existing standard.

pscott commented 1 year ago

Ok then happy to close this PR and add a comment for the auditors