Closed pscott closed 1 year ago
should we rename eth_tx
to l1_tx
? Might be worth being consistent to remove all mentions of 'eth' unless it specifically refers to the token itself
should we rename
eth_tx
tol1_tx
? Might be worth being consistent to remove all mentions of 'eth' unless it specifically refers to the token itself
I don't know about that, if I say out loud "you can authenticate via an eth signature" or "you can authenticate via an l1 signature" I feel like the former is clearer ?
should we rename
eth_tx
tol1_tx
? Might be worth being consistent to remove all mentions of 'eth' unless it specifically refers to the token itselfI don't know about that, if I say out loud "you can authenticate via an eth signature" or "you can authenticate via an l1 signature" I feel like the former is clearer ?
yeah true
validate
-> decided against, want to preserve SX-EVM compatibility and we feel like the wording is "ok"update_proposal
-> decided against, asupdate_proposal
can also update the metadata_uri, and I feel like it would be too verbosetarget
when appropriate https://github.com/snapshot-labs/sx-starknet/pull/590/commits/b9c2755d655820e2f86926400a54da7b2179908fl1_account_address
a571f1b728d8ac92369c11c7cb9996f0ccb1e1f5reinitialize
5bb2b0100c0905ab4e72479c3a1e7c14fbf31a3fEthBalanceOfVotingStrategy
4aa949e68cb02f2b38454e705285ce70db3ea80f && 74a7452490167be9a2f56b5de9ae0f151721da4c && https://github.com/snapshot-labs/sx-starknet/pull/590/commits/0b563e2c9f672b3afeb838bb1bac417dbac25fb4Closes #572