snapshot-labs / sx-starknet

Core smart contracts of Snapshot X for Starknet
https://docs.snapshotx.xyz
MIT License
118 stars 71 forks source link

refactor: N-10 Naming Suggestions #590

Closed pscott closed 1 year ago

pscott commented 1 year ago

Closes #572

Orland0x commented 1 year ago

should we rename eth_tx to l1_tx? Might be worth being consistent to remove all mentions of 'eth' unless it specifically refers to the token itself

pscott commented 1 year ago

should we rename eth_tx to l1_tx? Might be worth being consistent to remove all mentions of 'eth' unless it specifically refers to the token itself

I don't know about that, if I say out loud "you can authenticate via an eth signature" or "you can authenticate via an l1 signature" I feel like the former is clearer ?

Orland0x commented 1 year ago

should we rename eth_tx to l1_tx? Might be worth being consistent to remove all mentions of 'eth' unless it specifically refers to the token itself

I don't know about that, if I say out loud "you can authenticate via an eth signature" or "you can authenticate via an l1 signature" I feel like the former is clearer ?

yeah true