snapshout-remount-fs fails on args with double =

snapshotmanager / boom-boot

Boom Boot Manager

GNU General Public License v2.0

30 stars 4 forks source link

snapshout-remount-fs fails on args with double = #25

Closed aburmash closed 5 months ago

aburmash commented 5 months ago

in function def _arg_in_cmdline(cmdline, arg): systemd/snapshot-remount-fs if there a cmdline argument with double = ( for example rd.iscsi.param=node.session.timeo.replacement_timeout=6000) (word, _) = word.split("=") will fail. instead word = word.split("=")[0]seem to be a better universal choice to get word value.

bmr-cymru commented 5 months ago

Thanks: this is a bit of a silly bug that should have been caught earlier. Appreciate your taking the time to file an issue. I will put up a PR for this later today.

bmr-cymru commented 5 months ago

I've pushed a fix for this and another bug that I noticed while reviewing the script. These will both be in the next release, 1.6.1.