snapshotpl / ZfSnapGeoip

Maxmind Geoip module for Zend Framework 2
15 stars 4 forks source link

Reinvention of wheel #6

Open ojhaujjwal opened 10 years ago

ojhaujjwal commented 10 years ago

I recently found Geocoder library which is just too awesome and I discovered that this module can use Geocoder library to remove some duplicate code.

ojhaujjwal commented 10 years ago

For example, the library already has some entities like: https://github.com/geocoder-php/Geocoder/blob/master/src/Geocoder/Result/Geocoded.php

snapshotpl commented 10 years ago

It looks awesome, however it's idea for another module, becouse this is designed exactly for Maxmind library.

ojhaujjwal commented 10 years ago

Creating another module will be another reinvention of wheel. I think the module can be changed a little to support Geocoder library. But, that will be BC break. So, you need to tag a major release.

And, you can still use Maxmind library.

m-cameron commented 9 years ago

Do you have support for IP2Location LITE? It is a free geolocation database up to ZIP code level.

http://lite.ip2location.com