search

snapview / tokio-tungstenite

Future-based Tungstenite for Tokio. Lightweight stream-based WebSocket implementation
MIT License
1.88k stars 236 forks source link

Make handshake dependencies optional. #240

Closed Icelk closed 1 year ago

Icelk commented 2 years ago

This is the PR I promised in snapview/tungstenite-rs#296. It requires snapview/tungstenite-rs#300 to be merged and released before we can release this.

This adds a cargo feature named handshake which is enabled by default. Disabling it removes the handshake feature of tungstenite.

Icelk commented 2 years ago

I can confirm this works as expected. I disabled the handshake feature and handled that myself.

Icelk commented 2 years ago

The CI is failing because I added tungstenite as a path dependency for development. Should I add it as a git reference, so the CI succeeds?

daniel-abramov commented 2 years ago

Thanks for the changes! It's ok, let's wait until we merge the tungstenite and release it, so that we can merge this one and release it as well.

Icelk commented 1 year ago

Great! Thanks!

Icelk commented 1 year ago

Just a reminder: should the docs in README be updated?

daniel-abramov commented 1 year ago

Possibly. We did not document the connect feature though. But perhaps it makes sense to document both connect and handshake.