search

snar / bgpq3

bgpq3
BSD 2-Clause "Simplified" License
362 stars 53 forks source link

Support of Nokia (former Alcatel-Lucent) SR OS #30

Closed sha90w closed 7 years ago

sha90w commented 7 years ago

Hi Alexandre,

Just a support of Nokia (Alcatel-Lucent) SR OS. I hope you will find this useful to include in bgpq3.

Thanks!

snar commented 7 years ago

On Wed, Mar 01, 2017 at 12:10:32AM -0800, sha90w wrote:

Hi Snar,

Just a support of Nokia (Alcatel-Lucent) SR OS. I hope you will find this useful to include in bgpq3.

Very interesting, thanks.

However, there are some questions (sorry, have no exprience with Nokia/Alcatel routers and can't test myself):

a) begin/commit clauses are included into generated prefix-lists

snar@fri:~/compile/bgpq3>./bgpq3 -N as9002 configure router policy-options begin no prefix-list "NN" prefix-list "NN" [...] prefix 194.87.97.0/24 exact exit commit

but not included into ip-prefix-lists:

snar@fri:~/compile/bgpq3>./bgpq3 -NE as9002 configure filter match-list no ip-prefix-list "NN" ip-prefix-list "NN" create [...] prefix 194.87.96.0/23 exit

Question: shall these clauses be included into both variants or shall they not to be included into both ? Or am I missing something and begin/commit means something completely different ? If 'commit' means 'commit applied changes from candidate to running config' begin/commit shall be avoided..

b) Aggregation and ip-prefix-lists: is it not supported on Nokia at all (if so, -A flag use shall be prohibited explicitely), or this patch is incomplete ? Example: juniper vs. nokia modes:

snar@fri:~/compile/bgpq3>./bgpq3 -JAE as9002 | grep range route-filter 104.121.64.0/22 prefix-length-range /23-/23; snar@fri:~/compile/bgpq3>./bgpq3 -NAE as9002 | grep 104.121.64.0/22 prefix 104.121.64.0/22

... to be continued.

Thanks!

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

You can view, comment on, or merge this pull request online at:

https://github.com/snar/bgpq3/pull/30

Commit Summary

• Support of Nokia (former Alcatel-Lucent) SR OS

File Changes

• M README.md (6) • M bgpq3.c (12) • M bgpq3.h (3) • M bgpq3_printer.c (164)

Patch Links:

• https://github.com/snar/bgpq3/pull/30.patch • https://github.com/snar/bgpq3/pull/30.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.*

sha90w commented 7 years ago

Hi Alexandre,

My answers inline.

Just a support of Nokia (Alcatel-Lucent) SR OS.

I hope you will find this useful to include in bgpq3.

Very interesting, thanks.

However, there are some questions (sorry, have no exprience with Nokia/Alcatel routers and can't test myself):

a) begin/commit clauses are included into generated prefix-lists

snar@fri:~/compile/bgpq3>./bgpq3 -N as9002 configure router policy-options begin no prefix-list "NN" prefix-list "NN" [...] prefix 194.87.97.0/24 exact exit commit

but not included into ip-prefix-lists:

snar@fri:~/compile/bgpq3>./bgpq3 -NE as9002 configure filter match-list no ip-prefix-list "NN" ip-prefix-list "NN" create [...] prefix 194.87.96.0/23 exit

Question: shall these clauses be included into both variants or shall they not to be included into both ? Or am I missing something and begin/commit means something completely different ? If 'commit' means 'commit applied changes from candidate to running config' begin/commit shall be avoided..

begin/commit applied only for policy-options context to provide some granularity for routing policy modification.

Please look an output from the real router:

*A:SR1# configure router policy-options

*A:SR1# configure router policy-options prefix-list NN MINOR: CLI Could not change policy options because not in edit mode. Enter 'begin' to edit policy options.

But this behaviour doesn't applied for packet filter configuration:

*A:SR1# configure filter match-list ip-prefix-list NN create

A:SR1# configure filter match-list ip-prefix-list NN create A:SR1>config>filter>match-list>ip-pfx-list$ [no] apply-path + Configure auto-generated prefixes [no] description - Description for this ip prefix list [no] prefix - Create/delete an entry in the ip prefix list

Actually, in modern SR OS versions exists a transactional CLI like JunOS and XR OS, but policy-options edit mode exists independently from it.

b) Aggregation and ip-prefix-lists: is it not supported on Nokia at all (if so, -A flag use shall be prohibited explicitely), or this patch is incomplete ? Example: juniper vs. nokia modes:

snar@fri:~/compile/bgpq3>./bgpq3 -JAE as9002 | grep range route-filter 104.121.64.0/22 prefix-length-range /23-/23; snar@fri:~/compile/bgpq3>./bgpq3 -NAE as9002 | grep 104.121.64.0/22 prefix 104.121.64.0/22

Unfortunately in ip-prefix-list we can use only prefixes without any range modifiers, so you are correct - "-A" flag should not be applicable in this case:

*A:SR1>config>filter>match-list>ip-pfx-list$ prefix

... to be continued.

Thanks!

Thanks!

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ━━━━━━━━━━━━━━━━━━━

You can view, comment on, or merge this pull request online at:

https://github.com/snar/bgpq3/pull/30

Commit Summary

• Support of Nokia (former Alcatel-Lucent) SR OS

File Changes

• M README.md (6) • M bgpq3.c (12) • M bgpq3.h (3) • M bgpq3_printer.c (164)

Patch Links:

• https://github.com/snar/bgpq3/pull/30.patch • https://github.com/snar/bgpq3/pull/30.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.*

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/snar/bgpq3/pull/30#issuecomment-283731149, or mute the thread https://github.com/notifications/unsubscribe-auth/AD8p0sddQg0eWyvDo115BdvX_mfBTtrMks5rhwTUgaJpZM4MPVvO .

-- MYL2-RIPE

snar commented 7 years ago

On Thu, Mar 02, 2017 at 11:46:57AM -0800, sha90w wrote:

a) begin/commit clauses are included into generated prefix-lists [...] but not included into ip-prefix-lists:

begin/commit applied only for policy-options context to provide some granularity for routing policy modification.

Thanks, a) closed.

b) Aggregation and ip-prefix-lists: is it not supported on Nokia at all (if so, -A flag use shall be prohibited explicitely), or this patch is incomplete ? Example: juniper vs. nokia modes:

snar@fri:~/compile/bgpq3>./bgpq3 -JAE as9002 | grep range route-filter 104.121.64.0/22 prefix-length-range /23-/23; snar@fri:~/compile/bgpq3>./bgpq3 -NAE as9002 | grep 104.121.64.0/22 prefix 104.121.64.0/22

Unfortunately in ip-prefix-list we can use only prefixes without any range modifiers, so you are correct - "-A" flag should not be applicable in this case:

Thanks for clarification, flags -A, -R and -r made explicitely unapplicable for Nokia:

snar@fri:~/compile/bgpq3>./bgpq3 -NER 24 as9002 FATAL ERROR:Sorry, more-specific filters (-R 24) not supported on Nokia (-N) snar@fri:~/compile/bgpq3>./bgpq3 -NEr 24 as9002 FATAL ERROR:Sorry, more-specific filters (-R 32) not supported on Nokia (-N) snar@fri:~/compile/bgpq3>./bgpq3 -NEA as9002 FATAL ERROR:Sorry, aggregation (-A) is not supported on Nokia equipment (-N)

b) closed.

... to be continued.

c) manpage sync. done.

Merged and tagged as v0.1.35-rc (will become v0.1.35 soon).

Thanks again!