search

snar / bgpq3

bgpq3
BSD 2-Clause "Simplified" License
362 stars 53 forks source link

Further cleanup OpenBGPD prefix-sets #44

Closed cjeker closed 5 years ago

cjeker commented 5 years ago

Remove all backslashes from the generated OpenBGPD config. They are not needed. In -E mode it is perfectly fine to have empty prefix-sets. Using them will just work (the filter rule will never match since the set is empty).

cjeker commented 5 years ago

Hi, I just dropped to OpenBGPD related pull requests for bgpq3. It would be great if those could be added to the next release so that the soon to be released OpenBSD 6.4 release can use bgpq3 to generate better filter rules.

Cheers -- Claudio (OpenBGPD maintainer)

snar commented 5 years ago

On Tue, Oct 02, 2018 at 05:47:06AM -0700, Claudio Jeker wrote:

Hi, I just dropped to OpenBGPD related pull requests for bgpq3.

Thanks, one of these requests (prefix-sets cleanup) is already merged.

As for the other (as-set blocks) - it can't be accepted in current implementation as it is incompatible with older versions of OpenBGPD: according to https://man.openbsd.org/bgpd.conf as-sets is only present in OpenBSD-current, not even in OpenBSD 6.3 (even not saying about FreeBSD, that still ships openbgpd-5.2.20121209_3 in ports collection..).

It would be great if those could be added to the next release so that the soon to be released OpenBSD 6.4 release can use bgpq3 to generate better filter rules.

Cheers

Claudio (OpenBGPD maintainer)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.*