snar / bgpq3

bgpq3
BSD 2-Clause "Simplified" License
362 stars 53 forks source link

Fixed printing JunOS route-filter-list when the list of prefixes is e… #55

Closed aristima closed 3 years ago

aristima commented 4 years ago

…mpty. Instead of:

route-filter-list FOO { route-filter 0.0.0.0/0 orlonger reject; }

..we should have:

route-filter-list FOO { 0.0.0.0/0 orlonger reject; }

The first syntax does not pass JunOS commit check.

snar commented 4 years ago

On Thu, Jan 30, 2020 at 10:14:53PM -0800, Antti Ristimäki wrote:

…mpty. Instead of:

route-filter-list FOO { route-filter 0.0.0.0/0 orlonger reject; }

..we should have:

route-filter-list FOO { 0.0.0.0/0 orlonger reject; }

The first syntax does not pass JunOS commit check.

Thanks for reporting, fixed. Not merged because proposed patch breaks empty filters in policy-statements (-E).

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

You can view, comment on, or merge this pull request online at:

https://github.com/snar/bgpq3/pull/55

Commit Summary

• Fixed printing JunOS route-filter-list when the list of prefixes is empty. Instead of:

File Changes

• M bgpq3_printer.c (4)

Patch Links:

https://github.com/snar/bgpq3/pull/55.patchhttps://github.com/snar/bgpq3/pull/55.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.*