search

snare / voltron

A hacky debugger UI for hackers
MIT License
6.18k stars 414 forks source link

Impossible to get vertical registers view without additional info / dereferencing #226

Open ghost opened 6 years ago

ghost commented 6 years ago

When using Voltron's register view, the options for the view no longer allow for disabling register telescoping. The only way I've found to do it is by setting the view to horizontal view.

As a result this view from the wiki's Views section seems to no longer be supported: https://camo.githubusercontent.com/e08192d14a273920cb22903d1bfb58a399404435/687474703a2f2f692e696d6775722e636f6d2f724665665466492e706e67

This is the change in question. https://github.com/snare/voltron/commit/73729db44f85e330202ec67ae3e2916288e53b2b#diff-87d416120f97e512ea276c861b78f851

[Steps to Reproduce]

  1. Launch GDB with Voltron installed
  2. Open another terminal / make a split with tmux, terminator, etc...
  3. Attempt to create a registers view that is vertical but does not have extra info.
ghost commented 6 years ago

Maybe just rename the arg to '--hide-info', default value to False, action store True and just rearrange the if statement at 531 to:

if not self.args.hide_info:

I'd be happy to do the changes and send you a PR. Will have time this weekend. If someone gets to it before then that's cool too.

EDIT - Ended up just making the changes tonight. See PR below. Cheers.