snarfed / bridgy-fed

πŸŒ‰ A bridge between decentralized social network protocols
https://fed.brid.gy
Creative Commons Zero v1.0 Universal
639 stars 31 forks source link

Try harder to delete bridged accounts when the source account is deleted #1304

Closed breadguyyy closed 1 month ago

breadguyyy commented 2 months ago

https://bsky.app/profile/breadguyyy.c.wtf.ap.brid.gy the original account no longer exists for this one

snarfed commented 2 months ago

Ooh, thanks for reporting! Looks like we currently delete Bluesky bridged profiles when someone opts out, but not when they delete their fediverse account. We should! Should be straightforward.

breadguyyy commented 2 months ago

MVP πŸ™ cheers!

snarfed commented 2 months ago

Actually, I take it back. The immediate problem here was that when Bridgy Fed followed you back from @bsky.brid.gy@bsky.brid.gy, c.wtf choked on that Follow activity and returned 500 "error". I expect this is the same Pleroma incompatibility as #12 / https://git.pleroma.social/pleroma/pleroma/-/issues/3206.

Since c.wtf never got that follow, it never started sending Bridgy Fed your activities, including the Delete when you deleted your account, so Bridgy Fed never knew it should disable your bridged Bluesky account.

snarfed commented 2 months ago

Here's the Follow activity, sent at 2024-08-08 17:56:28 UTC:

POST https://c.wtf/users/breadguyyy/inbox
{
  "@context": "https://www.w3.org/ns/activitystreams",
  "type": "Follow",
  "id": "https://bsky.brid.gy/r/https://bsky.brid.gy/#follow-back-https://c.wtf/users/breadguyyy-2024-08-08T17:40:53.226091+00:00",
  "actor": "https://bsky.brid.gy/bsky.brid.gy",
  "object": "https://c.wtf/users/breadguyyy",
  "to": ["https://www.w3.org/ns/activitystreams#Public"]
}
cuducos commented 1 month ago

Same issue here. I added #nobridge to my website and apparently the user page does not exist anymore (as expected): https://fed.brid.gy/web/cuducos.me gives me a 404.

However, the Bluesky account still exists : /

It was a few minutes ago, but I was hoping not to leave the #nobrige live on my website for that long…

snarfed commented 1 month ago

OK, added an integration test for fediverse => Bluesky. If a fediverse account accepts @bsky.brid.gy@bsky.brid.gy's follow, we correctly deleted them.

@breadguyyy and @cuducos, I've deleted your bridged Bluesky accounts. Remaining work here is to add an integration test for web too.

snarfed commented 1 month ago

Done!

cuducos commented 1 month ago

Awesome ✨ Thank you so much : )

breadguyyy commented 1 month ago

MVP πŸ‘