snarfed / bridgy-fed

🌉 A bridge between decentralized social network protocols
https://fed.brid.gy
Creative Commons Zero v1.0 Universal
724 stars 39 forks source link

Attempt to follow @bsky.brid.gy@bsky.brid.gy from WordPress Friends plugin fails #1493

Closed solarbirdy closed 3 days ago

solarbirdy commented 6 days ago

Hi! Installed the Friends plugin to my selfhosted latest-WordPress instance running ActivityPub at https://solarbird.net/.

I then attempted to friend @bsky.brid.gy@bsky.brid.gy in order to allow ActivityPub follows from BlueSky. It fails with a “too many redirects” error:

Too many redirects (https://bsky.brid.gy/bsky.brid.gy)

I have filed this with the Friends plugin author as well, of course. But since following Mastodon accounts seems to work fine, it's quite possible they'll throw the ball back to me and say to ask you.

However it gets addressed, it would be very nice if I could follow @bsky.brid.gy@bsky.brid.gy from the WordPress Friends plugin with ActivityPub as I'm hoping that would work as an opt-in on the gateway, thus enabling BlueSky users to follow my Federated blog instance using standard Fediverse nomenclature.

Thank you! ^_^

snarfed commented 6 days ago

Hey, sorry for the trouble! I think I might see what's going on here. We don't currently serve Vary: Accept for AP actors like this, but we need to. I'll try that and see if it helps.

snarfed commented 6 days ago

Not confident that will solve your problem, though. I don't see that BF is serving multiple redirects or a loop. Guess we'll see.

solarbirdy commented 6 days ago

Thank you! I look forward to trying it! ^_^

Obviously I have no idea whether that error reflects what's actually going on or whether it's just a fallback error, so it totally could be misleading.

Will you note here when the change is in place, or otherwise, how best should I track it?

snarfed commented 6 days ago

Yup, I'll update here.

snarfed commented 5 days ago

@solarbirdy mind trying again? I give it 50/50 that this fixes your issue 😁

solarbirdy commented 5 days ago

Oh, already! Not at all, I'll give it a try right now...

No.

Dang.

Screenshot 2024-11-16 at 2 30 51 PM
snarfed commented 4 days ago

@solarbirdy the Friends plugin is evidently sending an unusual Accept header for AP/AS2 conneg that Bridgy Fed isn't understanding. I've added some logging, mind trying again?

solarbirdy commented 4 days ago

Gladly! Here we gooooo...

Done. Same result and error at the moment of course.

(3:03pm Cascadian/Pacific standard time.)

snarfed commented 4 days ago

Well that's odd. The Friends plugin isn't even trying to do AP conneg, it's fetching https://bsky.brid.gy/bsky.brid.gy with Accept: */*, which is wrong: https://www.w3.org/TR/activitypub/#retrieving-objects

@solarbirdy is this the latest version of the plugin? If so, you'll probably want to file a bug: https://github.com/akirk/friends/issues

solarbirdy commented 4 days ago

I am running the latest version. I've also already opened an issue - I contact both of you at the same time - over at the plugin support page. I know that Alex responds to posts there, and I will add this to it with a link.

I'll also ask whether I should open it as an issue on the Github side, and try to keep everybody up to date.

akirk commented 3 days ago

Thanks for all the debugging here! The reason the plugin sends an Accept: */* request first is that the feed discovery also needs to work for non-ActivityPub sources. The issue was actually that I set the redirect to a too low number, just raising it by 1 makes it work!

Screenshot 2024-11-18 at 08 49 51

solarbirdy commented 3 days ago

I came here to say it looked like it works and to give a link back!

https://wordpress.org/support/topic/attempting-to-follow-bridgyfed-the-fediverse-bluesky-bridge-fails/#post-18142632

Thanks to everybody, this was great :D

snarfed commented 3 days ago

Thank you @akirk!

solarbirdy commented 3 days ago

Got confirmation that it worked this morning too! :D

Seriously this is fun xD

https://mastodon.cloud/@SarekOfVulcan/113505224593928376