snarfed / bridgy

📣 Connects your web site to social media. Likes, retweets, mentions, cross-posting, and more...
https://brid.gy
Creative Commons Zero v1.0 Universal
710 stars 52 forks source link

Votes on polls cause repeated notifications #1550

Open edent opened 12 months ago

edent commented 12 months ago

This post is a reply to something which links to my blog:

https://mastodon.social/@Edent/111069219037380638

Every time someone votes on the poll, I get a new WordPress comment.

Screenshot of lots of identical comments.

I suspect because every time there is a vote, the post updates itself? But I'm not really sure.

snarfed commented 12 months ago

Ooh, interesting!

You're on the bleeding edge here, Bridgy doesn't officially support polls yet (https://github.com/snarfed/granary/issues/174), but agreed, it shouldn't be doing this regardless. Will look!

edent commented 12 months ago

Oh, I excel at causing trouble 😆

snarfed commented 12 months ago

Looks like this is from Bridgy Fed, not Bridgy Classic. Following up in https://github.com/snarfed/bridgy-fed/issues/641

snarfed commented 12 months ago

Hey @dshanske, the WordPress plugin supposedly added de-duplication in https://github.com/pfefferle/wordpress-webmention/issues/267 / https://github.com/pfefferle/wordpress-webmention/pull/386, but has it maybe regressed? These duplicate comments ^ have different source URLs, but they all have the same u-url. Example:

More on de-duping: https://indieweb.org/deduplication

snarfed commented 10 months ago

@dshanske friendly ping?

dshanske commented 10 months ago

I have a few Issues I'm investigating, but anything pre 5.0...we rewrote the code from scratch...we did add tests... but we might need more for this scenario.