search

snarfed / bridgy

📣 Connects your web site to social media. Likes, retweets, mentions, cross-posting, and more...
https://brid.gy
Creative Commons Zero v1.0 Universal
710 stars 52 forks source link

PPD: do not fetch individual permalinks if u-syndication URL is available in the h-feed #306

Closed kylewm closed 9 years ago

kylewm commented 9 years ago

This came up because http://davidpeach.co.uk/notes/ was missing a little piece of markup for u-url's, so Bridgy was not able to find the permalink urls in order to fetch them. But his feed page has the syndication urls, and we should get them from there, without needing fetch the permalink.

This change would make us a little more resilient across different sites/markups and also would be a nice small improvement in eliminating unnecessary fetches.

snarfed commented 9 years ago

thanks @kylewm!

snarfed commented 9 years ago

as discussed in irc, i'd like us to also merge h-entries from the the front page and rel-feed. holler if you want me to file a new issue for that.

snarfed commented 9 years ago

cc @davidpeach

kylewm commented 9 years ago

Ugh, I forgot about a critical aspect of this:

This came up because http://davidpeach.co.uk/notes/ was missing a little piece of markup for u-url's, so Bridgy was not able to find the permalink urls in order to fetch them. But his feed page has the syndication urls, and we should get them from there, without needing fetch the permalink.

but without the u-urls of course we wouldn't know what post the syndication url was associated with. So it wouldn't have helped this situation.

Nevertheless, I think it's worth making this change to save an HTTP GET when possible.

snarfed commented 9 years ago

you had me at "save an HTTP GET!" :P

good point about needing u-url. I'm sure we could come up with heuristics (your favorite word! :P) for inferring permalinks, but I'd rather not. thanks again for doing this!