snarkify / sirius

A Plonkish folding framework for Incrementally Verifiable Computation (IVC).
MIT License
106 stars 15 forks source link

feat(sfc): floor planner #251

Closed cyphersnake closed 1 month ago

cyphersnake commented 1 month ago

Now we using SimpleFloorPlanner but

/// A simple [`FloorPlanner`] that performs minimal optimizations.
///
/// This floor planner is suitable for debugging circuits. It aims to reflect the circuit
/// "business logic" in the circuit layout as closely as possible. It uses a single-pass
/// layouter that does not reorder regions for optimal packing.
#[derive(Debug)]
pub struct SimpleFloorPlanner;

and now we not reusing same rows for StepFoldingCircuit & StepCircuit and we need migrate to halo2::V1 or different FloorPlanner

cyphersnake commented 1 month ago

Blocker for #249

cyphersnake commented 1 month ago

First problem is https://github.com/snarkify/sirius/blob/ed75dcd6d0209a51f16856d67cf9933808b8a400/src/ivc/step_folding_circuit.rs#L211-L213

cyphersnake commented 1 month ago

floor_planner::V1 solves our problem.