search

snarkify / sirius

A Plonkish folding framework for Incrementally Verifiable Computation (IVC).
MIT License
106 stars 15 forks source link

refactor(ivc): take out step-circuit's ownership #286

Closed cyphersnake closed 3 weeks ago

cyphersnake commented 3 weeks ago

Motivation Our API should allow step-circuit to be changed between rounds of folding. As part of #285, we will change the private input (merkle-tree leaves changing) at each iteration of folding

Overview It's just that now IVC is taking the step circuit from the ref

cyphersnake commented 3 weeks ago

LGTM. Can you elaborate more on why take out the SC from StepCircuitContext will allow changing private input of SC? Or they are not related thing?

Related, now ownership over the step-circuit at IVC, so once it's constructed - we can't change anything inside it directly.

We need step-circuit to be passed inside the method every time, then we can make any changes to the private input between step_folds