snatch-dev / Convey

A simple recipe for .NET Core microservices.
https://convey-stack.github.io
MIT License
953 stars 174 forks source link

Support for multiple ports in consul for non httpclient discovery. #34

Open Rivendark opened 4 years ago

Rivendark commented 4 years ago

Was wondering if there was any plans to support multiple port registration for consul via appsettings file. Implementing gRPC into a demo app, and i would love to be able to utilize the consul service discovery for it as well, but without a httpclient. I cant access the ConsulService class, as it is internal sealed, and without the ability to register multiple ports to the Consul service, i would have to choose purely http or gRPC.

Rivendark commented 4 years ago

Upon further digging, i think i can use taggedAddresses to handle this, would it be possible to implement them into your package, or for me to do a PR for this?

Will still need to implement a new Consul Service to get the information, but that is straight forward.