search

snax4a / service-quotes-web

Service Quotes React.js web app
service-quotes-web.vercel.app
0 stars 0 forks source link

A payment can be made while previous one is still not resolved #14

Open SKVetr opened 3 years ago

SKVetr commented 3 years ago

What are the preconditions to reproduce this issue?

  1. There is completed service request in the system

What are the steps to reproduce this issue?

  1. Log in on customer account with unpaid Quote
  2. Enter unpaid Quote details
  3. Select paynow
  4. Press PAY
  5. Enter BLIK code: 222222 or 444444
  6. Return to unpaid Quote details
  7. Attempt to make another payment

What happens?

A new payment can be made while previous one is still not resolved.

What were you expecting to happen?

Paying for Quote is only possible when payment was not made or previous one did not finish with success. Possible timeout to prevent infinitely stuck payments?

Any logs, error output, etc?

Issue

Notes?

None.

snax4a commented 3 years ago

For now this is intended to work like that as we are not saving payment url to which user is redirected during payment initialization.

There might be scenario when user closes payment screen and later he decides to pay but won't have that payment url anymore. So right now we allow creating multiple payments until any of them is confirmed.

I will move this issue to future upgrades. Also we need to check if and when paynow payments expire because when payment expire and is no more available in paynow we need to allow additional payment creation.