Closed apcamargo closed 4 years ago
@snayfach I listed three points that I'd like to discuss before merging the PR (indicated with the [Up for discussion] in the post above).
Re #1 - Yes I only used a single MAG from a single sample for outlier detection. Using multiple samples and looking at covariation of coverage seems considerably more difficult. Would this require having a co-assembly?
Re #2 - A minimum of 1x coverage seems reasonable. This cutoff might be explored a bit more in a paper. Also the deviation from the mean/median might depend on the mean/median. Higher deviation might be expected for bins with lower average coverage.
Re #3 - Yes this is the same way I defined an outlier
Re #1 - Yes I only used a single MAG from a single sample for outlier detection. Using multiple samples and looking at covariation of coverage seems considerably more difficult. Would this require having a co-assembly?
Not necessarily. You can map reads from related samples (eg.: replicates) to your MAG.
I finished writing the README and did some testing. Everything seems to be ok. If you fine with the changes, the PR can be merged.
This PR adds the
coverage
module to MAGpurify.Changes
coverm
to compute the contig coverages from BAM files.--contig-end-exclusion 75
and--min-read-percent-identity 0.97
.--max-deviation
allows the user to change the stringency of the refinement.