search

snazy2000 / SnipeitPS

Powershell API Wrapper for Snipe-it
MIT License
181 stars 47 forks source link

Add Next Audit Date to New-SnipeItAudit.ps1 #256

Closed RussellLeVasseur closed 2 years ago

RussellLeVasseur commented 2 years ago

Added values to set next audit date per https://snipe-it.readme.io/reference/hardwareaudit params.

RussellLeVasseur commented 2 years ago

probably need a way to sanitize the date format. I need to also put instructions for the date at the top. Let me add that real quick.

RussellLeVasseur commented 2 years ago

Changes added to patch-1 branch. Please review and let me know if there's anything else I need to do or add.

RussellLeVasseur commented 2 years ago

@PetriAsi, @snazy2000 Happy Monday! Was wondering if this could get a look and get merged, please!

PetriAsi commented 2 years ago

Thanks! Looking good.
I was just wondering if this parameter should be called "next_audit_date" as it is in API? That way SnipeitPS parameters will always be same as in API. Yes ,I know that not all parameters are following that, but maybe we keep that goal. So could you change parameter name to "next_audit_date" and I'll merge it.

RussellLeVasseur commented 2 years ago

I originally had it as that, but tried to kinda match existing naming. I'm all for next_audit_date though. I'll change it in the morning.

PetriAsi commented 2 years ago

Great! And also retarget this PR to develop branch here.

RussellLeVasseur commented 2 years ago

Great! And also retarget this PR to develop branch here.

Re-targeted to develop and changed var to next_audit_date. Let me know if you see anything else needing changed. Thank you Petri!

PetriAsi commented 2 years ago

Looking good, but I just noticed just now that there's lots of other people commits included. Git can be tricky some times . I have done same kind of commit clean up for my PRs by rebasing my forked branch against upstream.

So, could you please do rebasing against upstream/develop by running 

git rebase -i upstream/develop

Then left only your own commits to your branch and this PR. Cleaning PR history will keep git commit logs usefull for everyone.

If you don't have upstream in you local repo just add it by

git remote add upstream https://github.com/snazy2000/SnipeitPS.git
git pull upstream
RussellLeVasseur commented 2 years ago

Looking good, but I just noticed just now that there's lots of other people commits included. Git can be tricky some times . I have done same kind of commit clean up for my PRs by rebasing my forked branch against upstream.

So, could you please do rebasing against upstream/develop by running

git rebase -i upstream/develop

Then left only your own commits to your branch and this PR. Cleaning PR history will keep git commit logs usefull for everyone.

If you don't have upstream in you local repo just add it by

git remote add upstream https://github.com/snazy2000/SnipeitPS.git
git pull upstream

Is there a way to do this with the Web GUI? I am not using git CLI.

PetriAsi commented 2 years ago

It seems that that web gui does not support rebasing. #isaacs/github#88 I'm using plain git for windows or plain git with linux and macos . It's quite easy to setup, just go ahead and try. Creating ssh-keys could feel tricky for the first time, but after that is done it's nice to use.

I just tested made local copy of your fork. And added upstream. I can made new PR from my repo if you dont have time clean your request. Commits are still authored by you. But I hope that you do install git client , then you can have you local git repo for dev and testing. Pushing to github is only when there's need to publish something or make new PR for SnipeitPS.

PetriAsi commented 2 years ago

it seems that you missed one $next_audit when changing that to $next_audit_date

PetriAsi commented 2 years ago

@RussellLeVasseur . I'll close this and merge your changes from cleaned up branch. Thanks for this change.