Fix/new snipe it user - Githubissues

Frank-Geisler commented 1 year ago

Hi!

There were some minor issues in New-SnipeitUser that I fixed:

Some Typos in the description
added password to be mandatory
added a test that if the password is less than 8 characters we will have an exception because the WebAPI does not like passwords with less than 8 characters.

Have a good one

Frank

PetriAsi commented 1 year ago

Thanks! I have been away for while. I did just quick overview of you PR and it seems to be fine and needed here. Just couple little things that should be changed:

PR should be done against develop branch here, not master
There seems to be some vscode related changes that should be removed from PR
As password length is input validation would it make more sense to do it at param section by adding validation script like: [ValidateScript({ $_.Length -ge 8})] and helpmessage [parameter(mandatory = $true, helpmessage="Password should be at least 8 characters.")] After those changes this is ready for merge.

Frank-Geisler commented 1 year ago

Moved the changes to develop branch

snazy2000 / SnipeitPS

Fix/new snipe it user #301