search

snazzy-d / sdc

The Snazzy D Compiler
MIT License
250 stars 55 forks source link

Use new contract syntax for non-complex contracts #330

Closed 0xEAB closed 1 year ago

0xEAB commented 1 year ago

Resolves #249. All formatting changes – incl. readability degradations – by sdfmt.

deadalnix commented 1 year ago

In principle, yes. But for some of these, the end result loses in readability. For most, it's an improvement.

This PR is a good example of why splitting things up is valuable. Let's not discuss each instance in this PR while most could be merged today. Instead, let's split this PR up into several that only move a file or a couple of related files, so most of it gets merged right away and we can discuss the specific cases where the result is not a slam dunk.

0xEAB commented 1 year ago

Here we go, I’ve split it up.