Closed 0xEAB closed 9 months ago
The intention is good, but execution, not so much.
First, the static if is completely unnecessary. But second, we actually aren't asserting what we actually want to assert: that the cast isn't losing information. Now, sure, one can argue the checks are equivalent, and this is true in this version of the code, but will it be in tomorow's? Let's check what we actually want to check here.
Explicitly convert loop indexes from
size_t
touint
.Fixes these deprecation warnings: