Add new method to POST request to /applications/{application_name}/platforms/{platform_name}/properties

sncf-connect-tech / hesperides-jenkins-lib

Shared lib for Jenkins pipelines to interact with Hesperides

GNU General Public License v3.0

4 stars 13 forks source link

Closed dedalusium closed 6 years ago

dedalusium commented 6 years ago

Currently the jenkins lib provide a method to GET platform properties but not update it. I'm working on a PR to add one.

Lucas-C commented 6 years ago

Isn't setPlatformProperties what you are looking for ?

dedalusium commented 6 years ago

Oh you're right, I think i missed it because of the private visibility, I'll update my PR to keep public method signature and use this private method

dedalusium commented 6 years ago

I updated my PR adding an Integration Test. Feel free to merge if it's ok.

Lucas-C commented 6 years ago

Looks good, tyvm !

Could you just add a mention of your change in CHANGELOG.md and your name or pseudonym in CONTRIBUTORS.md please ?

Lucas-C commented 6 years ago

Closing this: PR has been merged Thanks @dedalusium !