sncf-connect-tech / maze

Apache License 2.0
14 stars 4 forks source link

add logs functions at cluster level #6

Closed ylorenzati closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #6 into master will increase coverage by -0.49%.

@@            Coverage Diff            @@
##           master      #6      +/-   ##
=========================================
- Coverage   72.39%   71.9%   -0.49%     
=========================================
  Files          17      17              
  Lines         594     598       +4     
  Branches       36      34       -2     
=========================================
  Hits          430     430              
- Misses        164     168       +4
Impacted Files Coverage Δ
...n/scala/fr/vsct/dt/maze/topology/ClusterNode.scala 0% <ø> (ø) :white_check_mark:
.../main/scala/fr/vsct/dt/maze/topology/Cluster.scala 63.88% <ø> (-1.83%) :x:
...rc/main/scala/fr/vsct/dt/maze/core/Execution.scala 75% <ø> (-10.72%) :x:
...a/fr/vsct/dt/maze/topology/DockerClusterNode.scala 36.36% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 849364c...11eb0bf. Read the comment docs.

Willymontaz commented 7 years ago

@francois @yannick je propose de le faire en binôme lundi matin ok ? Sauf si bien sur c'est déjà poussé

Le 27 janv. 2017 16:17, "ylorenza" notifications@github.com a écrit :

@ylorenza commented on this pull request.

In src/main/scala/fr/vsct/dt/maze/topology/Cluster.scala https://github.com/voyages-sncf-technologies/maze/pull/6:

@@ -96,6 +96,9 @@ abstract class Cluster[T <: ClusterNode : ClassTag](var nodes: Seq[T] = Seq(), p Execution{nodes.toArray.filter(node => fn(node).execute())}.labeled("nodes filtered") }

  • def logs(): Execution[Map[String, Array[String]]] = {
  • Execution{nodes.map(node => (node.hostname, Commands.exec(node.logs))).toMap}

Je vais essayer, mais j'ai peur que ça dépasse mes compétences.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/voyages-sncf-technologies/maze/pull/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKbiTFywQj6d9yCqLAOLttSl7AMEVI4ks5rWgqJgaJpZM4Lv1bn .

Willymontaz commented 7 years ago

Ca te va ce refacto François ?

yannick commented 7 years ago