search

sneako / finch

Elixir HTTP client, focused on performance
MIT License
1.23k stars 114 forks source link

Dialyzer type error #258

Closed andyleclair closed 4 months ago

andyleclair commented 5 months ago

Hello! I believe that from version 0.16 to 0.17 a type error was introduced. Previously, :infinity was a valid option for, say, :pool_timeout but as of 0.17 the type was set to pos_integer (https://github.com/sneako/finch/blob/main/lib/finch.ex#L107)

I can confirm that I don't get dialyzer errors in 0.16 but I do in 0.17

sneako commented 4 months ago

Ah thank you for the report! The correct type should be timeout() rather than pos_integer() PRs are welcome :pray:

sneako commented 4 months ago

resolved in #259