search

sneako / finch

Elixir HTTP client, focused on performance
MIT License
1.26k stars 118 forks source link

fix types, appease dialyzer #261

Closed andyleclair closed 7 months ago

andyleclair commented 7 months ago

We need to not use when is_reference since the ref is technically an opaque type and we break that by using is_reference (or at least that's what i'm reading into dialyzer's output)

andyleclair commented 7 months ago

I'd also add a caching step for the PLTs so we don't have to generate these every run, but I'm not very familiar with GH Actions (most of my experience is with CircleCI). Suggestions welcome!

sneako commented 7 months ago

I'd also add a caching step for the PLTs so we don't have to generate these every run, but I'm not very familiar with GH Actions (most of my experience is with CircleCI). Suggestions welcome!

We can copy Mint 😅 https://github.com/elixir-mint/mint/blob/main/.github/workflows/main.yml

andyleclair commented 7 months ago

@sneako it looks like the cache is working, I can see the dialyzer run took 4 seconds and didn't generate PLTs on the latest run

sneako commented 7 months ago

Thank you!!