feat: implement handle_cancelled/2 pool callback

sneako / finch

Elixir HTTP client, focused on performance

MIT License

1.26k stars 118 forks source link

feat: implement handle_cancelled/2 pool callback #268

Closed oliveigah closed 6 months ago

oliveigah commented 6 months ago

closes https://github.com/sneako/finch/issues/257

context: https://github.com/sneako/finch/pull/267

This PR implements the new nimble pool callback handle_cancelled/2

oliveigah commented 6 months ago

@sneako, this version was tested on production by @pcorey and it solved the issue for him! (see the comments on https://github.com/sneako/finch/pull/267 for more details)

I've also added mimic (https://github.com/edgurgel/mimic) as a test dependency because it was the easiest way to emulate this bug on the unit tests. If you don't want to add it I can think about another way to achieve the same thing, just let me know.