GNOME 45 support - Githubissues

sneetsher / keyboard_modifiers_status

Gnome-Shell extension that shows keyboard modifiers status. It's useful when sticky keys are active.

GNU General Public License v3.0

21 stars 4 forks source link

GNOME 45 support #11

Closed jezek closed 8 months ago

jezek commented 10 months ago

These are minimum changes needed to run on GNOME 45. Specific changes are described in commit(s).

NOTE: I'm creating this PR as a draft, cause the latch & lock indications are broken when running this PR in GNOME 45 and I still haven't figured out why. I'm a beginner in developing & debugging extensions. If anyone knows how to fix, help is welcome.

sneetsher commented 10 months ago

Thank you @jezek for the shared effort. I will look into it. Hope they didn't change much.

jezek commented 10 months ago

Just a note. What I found out (from enabled logs), that the kbd-a11y-mods-state-changed is not triggering, so the _a11y_mods_update is not called ever.

jezek commented 10 months ago

Pardon me my question. You wrote some review comments. I know you also wrote Thank you, I will continue working on it. above, but I just want to be sure that I didn't misunderstood. Are the review comments just for you, or should I implement them?

sneetsher commented 10 months ago

@jezek Yeah, they are comments for myself. Just to know where I left off and look for what next check.

By the way, It seems there are more into Gnome 45. I still couldn't get it to enable or show debug logs. I will test upstream Gnome 45 updated demo, probable do a rewrite step by step to find what broken.

jezek commented 10 months ago

When testing & debugging I'm using the env GNOME_SHELL_SLOWDOWN_FACTOR=2 MUTTER_DEBUG_DUMMY_MODE_SPECS=1024x768 dbus-run-session -- gnome-shell --nested --wayland command, so I don't have to restart wayland session after making changes. I found out, that after this, the extension logs are being written to the output of the command, so to get just the logs I pipe the whole output to grep and filter just the extension logs (env GNOME_SHELL_SLOWDOWN_FACTOR=2 MUTTER_DEBUG_DUMMY_MODE_SPECS=1024x768 dbus-run-session -- gnome-shell --nested --wayland 2>&1 | grep KMS).

jezek commented 9 months ago

Hi @sneetsher , it's me again.

I've been using this extension, with this PR on Manjaro Linux, even when the latch & lock indications didn't work, cause it's more convenient, to see a modifier is pressed even when latch & lock indications aren't shown.

But, after last update, the latch& lock indications started working again. From what I deduce was a bug on gnome side, not a port bug, nor an API change.

sneetsher commented 8 months ago

@jezek I could get some time to test it.

Didn't work in Ubuntu 23.10 with gnome-shell 45.2. May be bug not yet fixed there, also it is was an upgrade from 22.04/23.04/23.10 . I will give it another shot with clean install.
Work perfect in Fedora 39 with gnome-shell 45.0

Thank you very much for effort. I am merging it.

sneetsher commented 8 months ago

@jezek I tested Ubuntu 23.10 Vanilla installation. It works perfectly too.