search

sneeuwballen / benchpress

Testing and benchmarking tool for logic-related programs.
BSD 2-Clause "Simplified" License
26 stars 8 forks source link

Add detailed statistics for the subcommand `show` #73

Closed Halbaroth closed 1 year ago

Halbaroth commented 1 year ago

It is useful to know how long solvers took to answer sat, unsat and unknown. In this PR, benchpress outputs more statistics for these answers while using the subcommand show.

I also add a .editorconfig ;)

Halbaroth commented 1 year ago

I will add an option to toggle detailed statistics. Otherwise the CI cannot succeed.

c-cube commented 1 year ago

Hu, I didn't realize it was that portable, my bad.

c-cube commented 1 year ago

No sure what the segfault is about, any idea?

Halbaroth commented 1 year ago

I can reproduce the bug on OCaml 4.08. I'll investigate.

Halbaroth commented 1 year ago

Bad news. The bug is localized in the bindings library sqlite3. It's fixed in its release 5.0.3 which requires at least OCaml 4.12: The issue: https://github.com/mmottl/sqlite3-ocaml/issues/47 The release: https://github.com/mmottl/sqlite3-ocaml/releases/tag/5.0.3

I didn't notice that you reported the issue ;p

c-cube commented 1 year ago

Oh yeah. Ok we can bump the minimal version.

Halbaroth commented 1 year ago

Sorry, I thought that you're going to bump the minimal version in a separated PR. I did it in the last commit of this PR. Notice that I modified by myself the opam files as it seems you don't use dune to generate them. I'm not sure it's correct :)

c-cube commented 1 year ago

Can you edit the github workflow to use 4.12 and 5.0 as OCaml versions?

c-cube commented 1 year ago

Thank you! :)