search

snehilvj / dash-mantine-components

Plotly Dash components based on Mantine React Components
https://www.dash-mantine-components.com
MIT License
580 stars 61 forks source link

Potential breaking changes #410

Open AnnMarieW opened 2 weeks ago

AnnMarieW commented 2 weeks ago

In line with our roadmap, we’re committed to minimizing breaking changes. However, I wanted to open a discussion about potential breaking changes that may come up.

DatePicker Component

Currently, the DatePicker in DMC corresponds to the DatePickerInput component from Mantine. Mantine also includes a stand-alone DatePicker that functions solely as a calendar, separate from the input dropdown. There was a request and a strong use case shared on Discord for adding this stand-alone DatePicker.

To avoid a breaking change, should we consider naming the new stand-alone DatePicker something else? On the other hand, to keep DMC aligned with the upstream Mantine library, it might be better to rename the existing DatePicker to DatePickerInput.

demk0r commented 1 week ago

The standalone DatePicker does have valid uses cases, so it would be great to add it to DMC. I recently also stumbled over this and was confused why the naming is not consistent between DMC and Mantine. I would prefer a breaking change in DMC to keep alignment with Mantine, since the necessary code adjustment for users would be a simple search and replace.

AnnMarieW commented 1 week ago

Update By popular demand, the DatePicker will be renamed to DatePickerInput in the next release. 0.15.0. For more info see Release Notes