search

snehring / zfsbackup

Quick and easy program to do one way sends of zfs datasets for backup purposes
MIT License
0 stars 1 forks source link

fails to backup datasets with children that are themselves being backed up #11

Closed snehring closed 4 years ago

snehring commented 5 years ago

this specific problem is with the has_stragglers method matching snapshots that belong to child datasets.

snehring commented 4 years ago

There's also an issue with the delete snapshots on the receiving side for descendant datasets.

snehring commented 4 years ago

https://github.com/snehring/zfsbackup/blob/25fd5b796c5a32351f752f0066b862a5987b9c82/zfsbackup.py#L579 receiving side snapshots are enumerated with -r (for some reason I cannot remember) which would also list snapshots of descendant filesystems which is extremely not desired.

snehring commented 4 years ago

Similarly the list invocation for get snapshots also features -r (again, presumably for some reason but I cannot remember why). Which is incorrect for this.