search

snejus / beetcamp

Bandcamp autotagger source for beets (https://beets.io)
GNU General Public License v2.0
68 stars 12 forks source link

track artists don't get added from VA album #13

Closed cphouser closed 3 years ago

cphouser commented 3 years ago

Hi, noticed when importing a VA album the individual track artists weren't getting imported. Idk if this is a persistent issue but would make sense that it was from looking at the track JSONDicts. Made a quick fix on a fork https://github.com/xeroxcat/beets-bandcamp/commit/78716b2994c852ae42309e01cec7cd16e462b86c that works for my circumstance. Would have made a PR but its a tiny fix and I could imagine you'd wanna implement it a bit more cleanly or run more comprehensive tests - I just made sure it worked for this album: https://alienheartrecordz.bandcamp.com/album/songs-for-the-interstellar-heart-vol-1 thanks for the plugin

snejus commented 3 years ago

Hey, happy that works for you! Just had a look at the html/json of your URL and it seems like bandcamp have updated their html! Previously a track was just a track name without any pointers about who's the artist (that's why that absolutely unreadable piece of parser code exists). Though it seems like it may now potentially get thrown out :) I'll cycle through a couple of more VA albums to check whether they contain the updates and will implement it.

Sick album by the way!

snejus commented 3 years ago

Accidentally closed it previously, thinking it was another issue!

It should now be handled in 0.9.0 :)

cphouser commented 3 years ago

Hey thanks for the quick response, I've had my head in other issues but thanks for maintaining this project! I'll update next time i'm importing and check it out!