Fix regex bug with lookahead

snejus / beetcamp

Bandcamp autotagger source for beets (http://beets.io)

GNU General Public License v2.0

64 stars 11 forks source link

Fix regex bug with lookahead #36

Closed Serene-Arc closed 1 year ago

Serene-Arc commented 2 years ago

My fix last time added an additional bug because of course it did. The lookahead present in the regex automatically disqualified any label or group beginning with the string 'com'. This commit fixes that, and I've included several additional tests that illustrate this. The same issue was present beforehand with names beginning with 'bandcamp' but that's much rarer than names beginning with 'com' so I guess that it never came up.

snejus commented 1 year ago

Nice, looks good. @Serene-Arc could you by any chance add a small note to CHANGELOG.md?

Serene-Arc commented 1 year ago

Done!

snejus commented 1 year ago

Lovely, thanks for this! I have a couple of more (unpushed) changes in the dev branches and some more to come, I'd predict this should get released at some point early October.