Closed ncraike closed 4 months ago
Very interesting! Thanks for reporting this, amazing!
The plugin indeed looks at the comments
field in the files that are being imported: back in the day when this was implemented Bandcamp search was not overly useful, so this URL would speed up the imports a lot.
I can indeed see in the logs it's trying to reach for the wrong URL:
bandcamp: Trying our guess https://supercom/album/products-of-science before searching
Could you by any chance double-check the comment
field in the first track of the album?
Ah don't worry! I just checked the regular expression that parses this comment and I can see the issue
LABEL_URL_IN_COMMENT = re.compile(r"Visit (https:[\w/.-]+com)")
Essentially, this assumed that label URLs always end with com, like bandcamp.com
, and thus it got confused about https://supercommuter.net
: the com bit here is in the middle of the URL rather than at the end, so the code just cut it off there: https://supercom muter.net.
I'll get this fixed!
Should should be fixed now
Sorry, I missed your replies earlier. I need to check my Github notification settings it seems.
Thanks so much for looking at this! I'm glad it was a pretty straightforward fix.
I'm not 100% sure what's causing this, but I'm getting an error trying to import some FLAC-format albums which I've downloaded from Bandcamp. The error seems to be a problem resolving a domain name related to the artistname, Supercommuter.
I have the beetcamp/bandcamp plugin enabled, but also the default metadata fetching from MusicBrainz. The verbose output does seem to suggest the error is from the beetcamp plugin, though.
If I run
beet -vv import path_to_album/
, I get this traceback:I was puzzled by the domain it seemed to be trying to lookup,
supercom
, since it's a truncated form of the artist name "Supercommuter".I had a look at the FLAC file tags, and they all have this in the Comments field:
If I use VLC to delete these comments, the import succeeds without error.
Is it possible the URL in the Comments field is triggering some attempt to resolve a truncated form of the domain?