search

snejus / beetcamp

Bandcamp autotagger source for beets (https://beets.io)
GNU General Public License v2.0
68 stars 12 forks source link

add: fb missing artist #72

Closed whatphilipcodes closed 1 month ago

whatphilipcodes commented 1 month ago

Just found that my alterations to the search (#68) break if the artist is empty (bandcamp search can't handle ' - title' syntax in search). This fixes the issue. I did not include a changelog entry as this feature has not been released yet and is already present in the log.

snejus commented 1 month ago

break if the artist is empty (bandcamp search can't handle ' - title' syntax in search)

Could you explain how does it break? Is there an exception thrown or it simply doesn't find the title you are looking for?

whatphilipcodes commented 1 month ago

The code works fine however, if the artist field is empty the query sent to bandcamp looks like this: ' - track title'. This won't return any results even if the track is present on bandcamp probably because their search assumes the title of the track to contain the dash if nothing is in front of it.

snejus commented 1 month ago

The code works fine however, if the artist field is empty the query sent to bandcamp looks like this: ' - track title'. This won't return any results even if the track is present on bandcamp probably because their search assumes the title of the track to contain the dash if nothing is in front of it.

This makes sense, thank you! Not ideal indeed. Regarding the change, see the comments I added the other day 🙂

whatphilipcodes commented 1 month ago

Yes I saw them but did not have the time then to get to it right away. Should be all included now :)