Improve settings ba1 to implement 1 - Githubissues

snek-at / front

I'm a 🐍 follow me.

Other

1 stars 2 forks source link

Improve settings ba1 to implement 1 #123

Closed pinterid closed 4 years ago

pinterid commented 4 years ago

Checklist:

[x] Have you added an explanation of what your changes do and why you'd like them to be included?
[x] Have you updated or added documentation for the change?
[x] Have you tested your changes with successful results?

Type of Changes:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation (non-breaking change which adds documentation)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

Currently it is not possible to save changes user settings, if the E-Mail field is empty. #108

What is the new behavior (if this is a feature change)?

Now the E-Mail field is declared as required and the changes cannot be saved if its content is empty. #108

Other information:

Ref: 🐍

pinterid commented 4 years ago

Have you checked if there are other empty fields causing the save problem too?

@schettn the mail field is the only required field (defined in the engine), although there was another bug on a user profile that if only the first name was entered and no last name, the name on a user profile was not displayed. But this issue was fixed in https://github.com/snek-at/front/pull/122.