Scripts for computing amplitude and phase maps - Githubissues

snek5000 / snek5000-cbox

Convective box

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

Scripts for computing amplitude and phase maps #53

Closed akhoubani closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (302a2d9) 97.96% compared to head (fa992b6) 97.96%.

:exclamation: Current head fa992b6 differs from pull request most recent head 2e0ee0c. Consider uploading reports for the commit 2e0ee0c to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #53 +/- ## ======================================= Coverage 97.96% 97.96% ======================================= Files 7 7 Lines 295 295 ======================================= Hits 289 289 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

paugier commented 1 year ago

Thanks!

[ ] Could you please put these files is a directory in doc/scripts with a meaningful name?
[ ] Could you add a short README.md file explaining how to use these scripts and with which scripts the simulations have been launched?

You only use these 2 files to produce all the data for the article ?

paugier commented 1 year ago

Could you please move the files to produce figures and supplementary materials in a subdirectory?

paugier commented 1 year ago

Thanks. Do you consider it ready? Can I merge?

akhoubani commented 1 year ago

Thanks. Do you consider it ready? Can I merge?

I guess it is ready to be merged.

paugier commented 1 year ago

Can you please add the url https://github.com/snek5000/snek5000-cbox/tree/main/doc/scripts/2022sidewall_conv_instabilities in the description of the Zenodo dataset?

paugier commented 1 year ago

And by the way, you can also add the Arxiv link... https://arxiv.org/abs/2304.12657