search

snes9xgit / snes9x

Snes9x - Portable Super Nintendo Entertainment System (TM) emulator
http://www.snes9x.com
Other
2.67k stars 461 forks source link

Request: Some Cheat Search & Editor improvements #918

Open ReyVGM opened 6 months ago

ReyVGM commented 6 months ago

Hey all.

I would like to request a few improvements to the Cheat Search and the editor. Hopefully it's nothing complicated to implement.

1) Right-click functionality (Cheat Editor): Right-click functionality when you highlight one of more cheat codes. Specifically, add menu entries for a "delete" and "toggle" options. See an example image of how FCEUX handles it.

1

3) Highlight Multiple Addresses (Cheat Search): This goes together with the request above. The ability to highlight multiple addresses and add them to the editor. When they are added, they should all have whatever their current value was.

ALREADY FULFILLED

2) Quick Add (Cheat Search) FULFILLED When you add an address from the cheat search menu, this screen pops up. Currently, you are forced to enter a new value before the cheat can be added and if you press OK without doing so, the address is not added. My request is for the address to be added to the cheat editor when you press OK without first having to enter a new value. A quick solution would be to just add the address with whatever its current value is.

Screen0088

4) Hotkey Shortcut:**FULFILLED** Please add the Cheat Editor & Search to the "Hotkey Configuration" menu. Example:

3

Thanks!

OV2 commented 6 months ago

I've added 2 and 4.

1: I do not see any benefit of a popup menu over clicking the checkbox or the delete button.

3: the add dialog is not currently made for any multi-address cheats. In your case that should probably add one cheat containing multiple addresses with one description.

ReyVGM commented 6 months ago

I've added 2 and 4.

1: I do not see any benefit of a popup menu over clicking the checkbox or the delete button.

3: the add dialog is not currently made for any multi-address cheats. In your case that should probably add one cheat containing multiple addresses with one description.

1) The benefit is that it's faster. But that's fine, it's not a dealbreaker.

3) For someone like me that searches for a lot of cheats, having to add them one by one is cumbersome. Personally, that add dialogue could be completely removed. That's just an extra unnecessary step since you can always edit the cheat on the editor after you've added it. Also, it prevents you from adding multiple addresses at once, which makes the process of cheat-finding slower.

Thanks for adding the other 2, though!