search

snes9xgit / snes9x

Snes9x - Portable Super Nintendo Entertainment System (TM) emulator
http://www.snes9x.com
Other
2.63k stars 453 forks source link

Hotkeys for cheat edit/search don't show. #933

Open ImSpecial opened 2 months ago

ImSpecial commented 2 months ago

This is just a display issue, they still work. Anyway, I noticed in 1.63 that they were not showing which lead me to believe they were either removed or that they were not mapped correctly, they were. This is minor but kinda annoying, especially if I take a long break and come back, I won't remember the exact hotkeys...

(Oh, and the "Cheat Search Dialog" is kinda cut off.)

1.62.3: hotkeys show 1 62 3

1.63.0: hotkeys no-show 1 63

I'm not crazy: hotkey set

bearoso commented 2 months ago

I don't know why this was done, but I can guess. Making the hotkeys configurable means the menu can't have the entries hard-coded. They have to be handled manually instead of by the menu API.

As for the binding dialog--it just didn't allocate enough space to accommodate the font size. Looks like 125% scale maybe?

ImSpecial commented 2 months ago

IIRC, I do use 125% DPI scaling.

OV2 commented 2 months ago

Making the hotkeys configurable means the menu can't have the entries hard-coded. They have to be handled manually instead of by the menu API.

That's exactly the reason why I removed them.

I'll take a look at the increased scaling when I can find the time.