search

sneumann / CAMERA

This is the git repository matching the Bioconductor package CAMERA: Collection of annotation related methods for mass spectrometry data
11 stars 22 forks source link

Several || left where _R_CHECK_LENGTH_1_LOGIC2_ barfs #75

Open sneumann opened 3 years ago

sneumann commented 3 years ago

Hi,

the vignette build of http://bioconductor.org/checkResults/devel/data-experiment-LATEST/mtbls2/ fails with an 

Error in is.na(object@sample) || length(object@sample) < 1 : 
  'length(x) = 16 > 1' in coercion to 'logical(1)'

which is in https://github.com/sneumann/CAMERA/blob/9f4552cb71d19a43cde84ccd4d8e6819d3f47f65/R/xsVisualise.R#L323 that has escaped fixes in bc0e9fd0ea46a5c67ef58876fa869fc69ac80e3a and 34795a2b3b5b422c1deba227aedcce8b5a79ad5a.