sneumann / Rdisop

This is the git repository matching the Bioconductor package Rdisop: Decomposition of Isotopic Patterns
4 stars 7 forks source link

Remove dependency on RcppClassic #15

Closed sneumann closed 5 years ago

sneumann commented 5 years ago

Rdisop is one of (the ?!) last package in BioC depending on RcppClassic. Since RcppClassic might disappear any day, this should be migrated to the (not so new anymore) Rcpp interface.

The R code https://github.com/sneumann/Rdisop/blob/master/R/Rdisop.R#L177 is calling into the C++ code at https://github.com/sneumann/Rdisop/blob/master/src/disop.cpp#L148

and everything below https://github.com/sneumann/Rdisop/tree/master/src/imslib should not require changes.

@David-J-R suggested to use Rcpp here.

Yours, Steffen