Closed jorainer closed 5 years ago
@lgatto, @sneumann, please have a look at this when you find the time.
I'm ok with this and happy to merge and commit to Bioc is needed.
It should be safe to merge I believe - if there are problems we still have enough time to fix. So, from my side, please merge and commit to Bioc - and let's keep the fingers crossed :)
Done.
Rewrite the C++ code extracting header (issue #205) and peak information from mass spec files for the
pwiz
backend.Tests and performance improvements for the new
header
implementation are shown in issue #205.Tests and performance comparisons of the new C++ code for
peaks
is below. The main differences to the old implementation are that 1) the for loop is moved down to C++ and 2) one for loop within the old C++ code was avoided. No real great performance improvements, but IMHO it simplifies the (C++) code.Note: the
.peaks
call above uses the original implementation, the.peaks2
the updated code. In the PR.peaks
is replaced by.peaks2
.