sneumann / mzR

This is the git repository matching the Bioconductor package mzR: parser for netCDF, mzXML, mzData and mzML files (mass spectrometry data)
40 stars 26 forks source link

Feature/update pwiz 3 0 21263 #256

Closed sneumann closed 2 years ago

sneumann commented 2 years ago

David's work towards fixing windows

jorainer commented 2 years ago

All fine on macOS (except warnings):

~/tmp ❯❯❯ R-brew CMD check mzR_2.29.2.tar.gz
* using log directory ‘/Users/jo/tmp/mzR.Rcheck’
* using R version 4.1.2 (2021-11-01)
* using platform: x86_64-apple-darwin17.0 (64-bit)
* using session charset: UTF-8
* checking for file ‘mzR/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘mzR’ version ‘2.29.2’
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... NOTE
Found the following hidden files and directories:
  .BBSoptions
  .github
These were most likely included in error. See section ‘Package
structure’ in the ‘Writing R Extensions’ manual.
* checking for portable file names ... WARNING
Found the following file with a non-portable file name:
  src/boost/serialization/collection_size_type copy.hpp
These are not fully portable file names.
See section ‘Package structure’ in the ‘Writing R Extensions’ manual.
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘mzR’ can be installed ... WARNING
Found the following significant warnings:
  pwiz/data/proteome/Modification.cpp:89:5: warning: 'auto_ptr<pwiz::chemistry::Formula>' is deprecated [-Wdeprecated-declarations]
  pwiz/utility/misc/TabReader.cpp:44:22: warning: assigning field to itself [-Wself-assign-field]
See ‘/Users/jo/tmp/mzR.Rcheck/00install.out’ for details.
* checking installed package size ... NOTE
  installed size is 12.9Mb
  sub-directories of 1Mb or more:
    libs  11.4Mb
* checking package directory ... OK
* checking ‘build’ directory ... OK
* checking DESCRIPTION meta-information ... NOTE
Versioned 'LinkingTo' value for ‘Rhdf5lib’ is only usable in R >= 3.0.2
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking line endings in shell scripts ... OK
* checking line endings in C/C++/Fortran sources/headers ... OK
* checking line endings in Makefiles ... OK
* checking compilation flags in Makevars ... OK
* checking for GNU extensions in Makefiles ... NOTE
GNU make is a SystemRequirements.
* checking for portable use of $(BLAS_LIBS) and $(LAPACK_LIBS) ... OK
* checking use of PKG_*FLAGS in Makefiles ... OK
* checking include directives in Makefiles ... OK
* checking compiled code ... NOTE
File ‘mzR/libs/mzR.so’:
  Found ‘__ZNSt3__14cerrE’, possibly from ‘std::cerr’ (C++)
    Objects: ‘./pwiz/data/common/Unimod.o’,
      ‘./pwiz/data/msdata/SpectrumListBase.o’,
      ‘./pwiz/data/msdata/BinaryDataEncoder.o’,
      ‘./pwiz/data/msdata/SpectrumWorkerThreads.o’,
      ‘./pwiz/utility/misc/sha1calc.o’
  Found ‘__ZNSt3__14coutE’, possibly from ‘std::cout’ (C++)
    Objects: ‘./pwiz/utility/chemistry/Chemistry.o’,
      ‘./pwiz/utility/misc/sha1calc.o’

Compiled code should not call entry points which might terminate R nor
write to stdout/stderr instead of to the console, nor use Fortran I/O
nor system RNGs.

See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual.
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ...
  Running ‘runTests.R’
 OK
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking running R code from vignettes ...
  ‘mzR.Rmd’ using ‘UTF-8’... OK
 NONE
* checking re-building of vignette outputs ... OK
* checking PDF version of manual ... OK
* DONE

Status: 2 WARNINGs, 5 NOTEs
See
  ‘/Users/jo/tmp/mzR.Rcheck/00check.log’
for details.
sneumann commented 2 years ago

The windows failure is unrelated to the PR itself and due to https://github.com/sneumann/mzR/issues/258. Yours, Steffen